Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ARG query to A01.29 in afd_checklist.en.json and updated the le… #927

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

asukumar22
Copy link
Contributor

@asukumar22 asukumar22 commented Sep 26, 2024

…arn more link with right doc

Added ARG query to A01.29 in afd_checklist.en.json and updated the learn more link with right doc

Description

Please provide a detailed description of your changes.

Related Issue

Link to any related issues or discussions here. This helps reviewers understand the context and the need for your changes.

Checklist

  • I've tested my changes to ensure they are ready for review.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the documentation (if applicable).
  • Resource Graph queries have been included (and tested) for recommendations where ever possible1.
  • Resource Graph queries have NOT been included (please explain below).

Additional Information

Is there any additional context, screenshots, or considerations that might help in the review process? Please include them here.

Reviewer Notes

Is there a specific area you’d like feedback on? Please highlight it here. We're here to help and learn together! 💡

Footnotes

  1. Details on how to add Azure Resource Graph queries to recommendations can be found here.

…arn more link with right doc

Added ARG query to A01.29 in afd_checklist.en.json and updated the learn more link with right doc
@@ -186,7 +186,8 @@
"guid": "17ba124b-127d-42b6-9322-388d5b2bbcfc",
"id": "A01.29",
"severity": "High",
"link": "https://learn.microsoft.com/azure/web-application-firewall/ag/application-gateway-waf-request-size-limits#request-body-inspection"
"graph" : "resources | where type =~ 'microsoft.network/frontdoorwebapplicationfirewallpolicies' | where properties['policySettings']['requestBodyCheck'] =~ "Enabled"| extend compliant = properties['policySettings']['requestBodyCheck'] =~ 'Enabled' | distinct id, name, compliant",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use single quotes (instead of double quotes) inside of the ARG query string

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with single quotes, thanks Jose! :)

@asukumar22 asukumar22 marked this pull request as draft September 26, 2024 21:14
@asukumar22 asukumar22 marked this pull request as ready for review September 26, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants